Skip to content

Commit

Permalink
descriptionContent -> screenButtonsHelpText, see phetsims/joist#989
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Nov 5, 2024
1 parent d3b858a commit 73184b3
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions js/RatioAndProportionStrings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ type StringsType = {
'detailsButtonPatternStringProperty': LocalizedStringProperty;
'detailsButtonWithCurrentChallengePatternStringProperty': LocalizedStringProperty;
'discover': {
'homeScreenDescriptionStringProperty': LocalizedStringProperty;
'screenButtonsHelpTextStringProperty': LocalizedStringProperty;
'screenSummary': {
'paragraph1StringProperty': LocalizedStringProperty;
'paragraph2StringProperty': LocalizedStringProperty;
Expand All @@ -154,7 +154,7 @@ type StringsType = {
'bothHandsGestureDescriptionHelpTextStringProperty': LocalizedStringProperty;
};
'create': {
'homeScreenDescriptionStringProperty': LocalizedStringProperty;
'screenButtonsHelpTextStringProperty': LocalizedStringProperty;
'screenSummary': {
'paragraph1StringProperty': LocalizedStringProperty;
'paragraph2StringProperty': LocalizedStringProperty;
Expand Down
2 changes: 1 addition & 1 deletion js/create/CreateScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class CreateScreen extends Screen<RAPModel, CreateScreenView> {
tandem: tandem,
homeScreenIcon: new CreateScreenIcon(),
name: RatioAndProportionStrings.screen.createStringProperty,
descriptionContent: RatioAndProportionStrings.a11y.create.homeScreenDescriptionStringProperty,
screenButtonsHelpText: RatioAndProportionStrings.a11y.create.screenButtonsHelpTextStringProperty,
createKeyboardHelpNode: () => new CreateScreenKeyboardHelpContent()
}
);
Expand Down
2 changes: 1 addition & 1 deletion js/discover/DiscoverScreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class DiscoverScreen extends Screen<RAPModel, DiscoverScreenView> {
tandem: tandem,
homeScreenIcon: new DiscoverScreenIcon(),
name: RatioAndProportionStrings.screen.discoverStringProperty,
descriptionContent: RatioAndProportionStrings.a11y.discover.homeScreenDescriptionStringProperty,
screenButtonsHelpText: RatioAndProportionStrings.a11y.discover.screenButtonsHelpTextStringProperty,
createKeyboardHelpNode: () => new DiscoverScreenKeyboardHelpContent()
};

Expand Down
4 changes: 2 additions & 2 deletions ratio-and-proportion-strings_en.json
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@
"value": "{{stateOfSim}} {{leftHand}} {{rightHand}} {{currentChallenge}}"
},
"discover": {
"homeScreenDescription": {
"screenButtonsHelpText": {
"value": "Explore and discover set challenge ratios."
},
"screenSummary": {
Expand Down Expand Up @@ -387,7 +387,7 @@
}
},
"create": {
"homeScreenDescription": {
"screenButtonsHelpText": {
"value": "Set your own challenge ratios to explore."
},
"screenSummary": {
Expand Down

0 comments on commit 73184b3

Please sign in to comment.