Skip to content

Commit

Permalink
fix lint, #384
Browse files Browse the repository at this point in the history
  • Loading branch information
zepumph committed Oct 24, 2024
1 parent 48669e7 commit bd6ee7a
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion js/eslint/rules/explicit-method-return-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* @copyright 2022 University of Colorado Boulder
*/

const { ESLintUtils } = require( '@typescript-eslint/utils' ); // eslint-disable-line phet/require-statement-match
const { ESLintUtils } = require( '@typescript-eslint/utils' );

// these are still MethodDefinition nodes, but don't require an annotation
const exemptMethods = [ 'get', 'set', 'constructor' ];
Expand Down
2 changes: 1 addition & 1 deletion js/eslint/rules/require-property-suffix.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* @copyright 2022 University of Colorado Boulder
*/

const { ESLintUtils } = require( '@typescript-eslint/utils' ); // eslint-disable-line phet/require-statement-match
const { ESLintUtils } = require( '@typescript-eslint/utils' );

const visit = ( context, propertyNode ) => {

Expand Down
3 changes: 1 addition & 2 deletions js/grunt/lint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ import { spawn } from 'child_process';
import fs from 'fs';
import _ from 'lodash';
import path from 'path';
import getDataFile from '../common/getDataFile.js';
import showCommandLineProgress from '../common/showCommandLineProgress';
import getOption from './tasks/util/getOption.js';
import getDataFile from '../common/getDataFile.js';

const ESLINT_COMMAND = path.join( `${__dirname}/../../node_modules/.bin/eslint` );
type LintResult = { ok: boolean };
Expand All @@ -40,7 +40,6 @@ export type LintOptions = {
export type RequiredReposInLintOptions = Partial<LintOptions> & Pick<LintOptions, 'repos'>;

// Require ESLint from the correct path
// eslint-disable-next-line phet/require-statement-match
const { ESLint } = require( 'eslint' );

const DO_NOT_LINT = [ 'babel', 'phet-vite-demo' ];
Expand Down
2 changes: 1 addition & 1 deletion js/scripts/repo-report.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* TODO https://github.com/phetsims/tasks/issues/942 This is a "quick" version which could benefit from documentation, better command line hygiene, more options, etc.
*/

const { exec } = require( 'child_process' ); // eslint-disable-line phet/require-statement-match
const { exec } = require( 'child_process' );

exec( 'git rev-list main', ( error, stdout, stderr ) => {
if ( error ) {
Expand Down
1 change: 0 additions & 1 deletion js/scripts/start-dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
* @author Jesse Greenberg (PhET Interactive Simulations)
*/

// eslint-disable-next-line phet/require-statement-match
const { spawn, exec } = require( 'child_process' );
const path = require( 'path' );
const gruntCommand = require( '../common/gruntCommand' );
Expand Down

0 comments on commit bd6ee7a

Please sign in to comment.