Skip to content

Commit

Permalink
use default accessibleName for Dialog, #82
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Nov 7, 2024
1 parent a637911 commit 8b19c52
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
1 change: 0 additions & 1 deletion js/ModelsOfTheHydrogenAtomStrings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ type StringsType = {
'monochromaticStringProperty': LocalizedStringProperty;
'mySnapshotsStringProperty': LocalizedStringProperty;
'plumPuddingStringProperty': LocalizedStringProperty;
'quantumNumbersStringProperty': LocalizedStringProperty;
'radialDistanceStringProperty': LocalizedStringProperty;
'schrodingerStringProperty': LocalizedStringProperty;
'spectraScreenButtonsHelpTextStringProperty': LocalizedStringProperty;
Expand Down
10 changes: 2 additions & 8 deletions js/common/view/QuantumNumbersInfoDialog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,14 @@ export default class QuantumNumbersInfoDialog extends Dialog {

const spacing = new RichText( 'X', CONTENT_TEXT_OPTIONS ).height;

const bodyBox = new VBox( {
const content = new VBox( {
align: 'left',
spacing: spacing,
children: [ nlmText, nText, lText, mText ]
} );

const content = new VBox( {
align: 'center',
spacing: spacing,
children: [ titleText, bodyBox ]
} );

super( content, {
accessibleName: ModelsOfTheHydrogenAtomStrings.a11y.quantumNumbersStringProperty,
title: titleText,
tandem: tandem
} );
}
Expand Down
3 changes: 0 additions & 3 deletions models-of-the-hydrogen-atom-strings_en.json
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,6 @@
"plumPudding": {
"value": "Plum Pudding"
},
"quantumNumbers": {
"value": "Quantum Numbers"
},
"radialDistance": {
"value": "Radial Distance"
},
Expand Down

0 comments on commit 8b19c52

Please sign in to comment.