Skip to content

Commit

Permalink
use default accessibleName for AquaRadioButton instances, #82
Browse files Browse the repository at this point in the history
  • Loading branch information
pixelzoom committed Nov 9, 2024
1 parent 83d63ad commit 4765e38
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 18 deletions.
2 changes: 2 additions & 0 deletions images/classicalSolarSystemExplosion_png.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/* eslint-disable */
/* @formatter:off */

import asyncLoader from '../../phet-core/js/asyncLoader.js';

const image = new Image();
Expand Down
2 changes: 2 additions & 0 deletions images/plumPudding_png.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/* eslint-disable */
/* @formatter:off */

import asyncLoader from '../../phet-core/js/asyncLoader.js';

const image = new Image();
Expand Down
8 changes: 4 additions & 4 deletions js/ModelsOfTheHydrogenAtomStrings.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
// Copyright 2021-2024, University of Colorado Boulder

/* eslint-disable */
/* @formatter:off */

/**
* Auto-generated from modulify, DO NOT manually modify.
*/
/* eslint-disable */
/* @formatter:off */

import getStringModule from '../../chipper/js/getStringModule.js';
import type LocalizedStringProperty from '../../chipper/js/LocalizedStringProperty.js';
import modelsOfTheHydrogenAtom from './modelsOfTheHydrogenAtom.js';
Expand Down Expand Up @@ -93,7 +95,6 @@ type StringsType = {
'lightSourceStringProperty': LocalizedStringProperty;
'lightSourceModeStringProperty': LocalizedStringProperty;
'lightSourceModeHelpTextStringProperty': LocalizedStringProperty;
'monochromaticStringProperty': LocalizedStringProperty;
'mySnapshotsStringProperty': LocalizedStringProperty;
'plumPuddingStringProperty': LocalizedStringProperty;
'radialDistanceStringProperty': LocalizedStringProperty;
Expand All @@ -111,7 +112,6 @@ type StringsType = {
'wavelengthStringProperty': LocalizedStringProperty;
'wavelengthHelpTextStringProperty': LocalizedStringProperty;
'wavelengthNanometersStringProperty': LocalizedStringProperty;
'whiteStringProperty': LocalizedStringProperty;
}
};

Expand Down
8 changes: 0 additions & 8 deletions js/common/view/LightModeRadioButtonGroup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,11 @@ export default class LightModeRadioButtonGroup extends HorizontalAquaRadioButton
{
value: 'white',
createNode: () => new Text( ModelsOfTheHydrogenAtomStrings.whiteStringProperty, TEXT_OPTIONS ),
options: {
//TODO https://github.com/phetsims/models-of-the-hydrogen-atom/issues/82 Use default discoverable from Text.
accessibleName: ModelsOfTheHydrogenAtomStrings.a11y.whiteStringProperty
},
tandemName: 'whiteRadioButton'
},
{
value: 'monochromatic',
createNode: () => new Text( ModelsOfTheHydrogenAtomStrings.monochromaticStringProperty, TEXT_OPTIONS ),
options: {
//TODO https://github.com/phetsims/models-of-the-hydrogen-atom/issues/82 Use default discoverable from Text.
accessibleName: ModelsOfTheHydrogenAtomStrings.a11y.monochromaticStringProperty
},
tandemName: 'monochromaticRadioButton'
}
];
Expand Down
6 changes: 0 additions & 6 deletions models-of-the-hydrogen-atom-strings_en.json
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,6 @@
"lightSourceModeHelpText": {
"value": "Choose type of light emitted by light source."
},
"monochromatic": {
"value": "Monochromatic"
},
"mySnapshots": {
"value": "My Snapshots"
},
Expand Down Expand Up @@ -279,9 +276,6 @@
},
"wavelengthNanometers": {
"value": "{{wavelength}} nanometers"
},
"white": {
"value": "White"
}
}
}

0 comments on commit 4765e38

Please sign in to comment.