Better default for screen buttons help text, see #989

phetsims · Nov 6, 2024 · 13c1f31 · 13c1f31
1 parent 07dea6d
commit 13c1f31
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/joist-strings_en.json b/joist-strings_en.json
@@ -331,6 +331,9 @@
     "screenNamePattern": {
       "value": "{{name}} Screen"
     },
+    "goToScreenPattern": {
+      "value": "Go to {{name}} Screen."
+    },
     "screenSimPattern": {
       "value": "{{screenName}}, {{simName}}"
     },

diff --git a/js/JoistStrings.ts b/js/JoistStrings.ts
@@ -153,6 +153,7 @@ type StringsType = {
     'simScreensStringProperty': LocalizedStringProperty;
     'simScreenStringProperty': LocalizedStringProperty;
     'screenNamePatternStringProperty': LocalizedStringProperty;
+    'goToScreenPatternStringProperty': LocalizedStringProperty;
     'screenSimPatternStringProperty': LocalizedStringProperty;
     'homeStringProperty': LocalizedStringProperty;
     'homeScreenDescriptionStringProperty': LocalizedStringProperty;

diff --git a/js/Screen.ts b/js/Screen.ts
@@ -38,6 +38,7 @@ import ScreenView from './ScreenView.js';
 import TModel from './TModel.js';
 
 const screenNamePatternStringProperty = JoistStrings.a11y.screenNamePatternStringProperty;
+const goToScreenPatternStringProperty = JoistStrings.a11y.goToScreenPatternStringProperty;
 const screenSimPatternStringProperty = JoistStrings.a11y.screenSimPatternStringProperty;
 const simScreenStringProperty = JoistStrings.a11y.simScreenStringProperty;
 
@@ -247,8 +248,8 @@ class Screen<M extends TModel, V extends ScreenView> extends PhetioObject {
     }
     else if ( this.nameProperty.value ) {
 
-      // Fall back to "{{Screen Name}} Screen" as a default.
-      this.screenButtonsHelpText = new PatternStringProperty( screenNamePatternStringProperty, {
+      // Fall back to "Go to {{Screen Name}} Screen" as a default.
+      this.screenButtonsHelpText = new PatternStringProperty( goToScreenPatternStringProperty, {
         name: this.nameProperty
       }, { tandem: Tandem.OPT_OUT } );
     }