Prepared for release

README.md

@@ -16,11 +16,11 @@ It consists of the following sub-projects:
 
 This solution is CEF compliant. See the test report at https://ec.europa.eu/cefdigital/wiki/download/attachments/82773297/phase4%20AS4%20test%20runs.zip?version=1&modificationDate=1565683321725&api=v2
 
-This solution is PEPPOL compliant. See the test report at https://github.com/phax/phase4/blob/master/docs/PEPPOL/TestBedReport-POP000306-20190906T103327.pdf
+This solution is Peppol compliant. See the test report at https://github.com/phax/phase4/blob/master/docs/PEPPOL/TestBedReport-POP000306-20190906T103327.pdf
 
 ## News and noteworthy
 
-* v0.9.4 - work in progress
+* v0.9.4 - 2019-11-20
     * Updated to ph-commons 9.3.8
     * Added OCSP/CLR check for Peppol certificates
     * Added support for validation of outgoing Peppol messages using the default Peppol Schematrons
@@ -155,9 +155,7 @@ The properties have the following meaning
 
 ## Subproject phase4-peppol-client
 
-The contained project contains a stub "main" class called `MainPhase4PeppolSender` - it contains all the parameters with some example values so that you can start easily. As a prerequisite, the files `phase4.properties` and `crypto.properties` must be filled out correctly and your PEPPOL certificate must be provided (the default configured name is `test-ap.p12`).
-
-When you are using this library embedded into your code, it is recommended to use class `Phase4PeppolSender` to do the heavy lifting. 
+The contained project contains a class called `Phase4PeppolSender.Builder` - it contains all the parameters with some example values so that you can start easily. As a prerequisite, the files `phase4.properties` and `crypto.properties` must be filled out correctly and your Peppol AP certificate must be provided (the default configured name is `test-ap.p12`).
 
 ## Building from source
 

phase4-peppol-client/src/main/java/com/helger/phase4/peppol/Phase4PeppolSender.java

@@ -320,8 +320,11 @@ public static StandardBusinessDocument createSBDH (@Nonnull final IParticipantId
    *         failed or the SMP certificate is invalid.
    * @throws Phase4PeppolException
    *         if something goes wrong
+   * @deprecated Will be made "private" in the next release. Please use
+   *             {@link #builder()} instead.
    */
   @Nonnull
+  @Deprecated
   public static ESuccess sendAS4Message (@Nonnull final HttpClientFactory aHttpClientFactory,
                                          @Nonnull final IPMode aSrcPMode,
                                          @Nonnull final IDocumentTypeIdentifier aDocTypeID,
@@ -517,7 +520,8 @@ public static Builder builder ()
   }
 
   /**
-   * The builder class for sending AS4 messages using Peppol specifics.
+   * The builder class for sending AS4 messages using Peppol specifics. Use
+   * {@link #sendMessage()} to trigger the main transmission.
    *
    * @author Philip Helger
    * @since 0.9.4
@@ -950,6 +954,18 @@ public boolean isEveryRequiredFieldSet ()
       return true;
     }
 
+    /**
+     * Synchronously send the AS4 message. Before sending,
+     * {@link #isEveryRequiredFieldSet()} is called to check that the mandatory
+     * elements are set.
+     *
+     * @return {@link ESuccess#FAILURE} if not all mandatory parameters are set
+     *         or if sending failed, {@link ESuccess#SUCCESS} upon success.
+     *         Never <code>null</code>.
+     * @throws Phase4PeppolException
+     *         In case of any error
+     * @see #isEveryRequiredFieldSet()
+     */
     @Nonnull
     public ESuccess sendMessage () throws Phase4PeppolException
     {

phase4-peppol-client/src/test/java/com/helger/phase4/peppol/MainPhase4PeppolSender.java

@@ -67,6 +67,7 @@ public final class MainPhase4PeppolSender
 {
   private static final Logger LOGGER = LoggerFactory.getLogger (MainPhase4PeppolSender.class);
 
+  @SuppressWarnings ("deprecation")
   public static void main (final String [] args)
   {
     // Provide context