fixes #21 class side methods are not really nice #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creation methods. This change exracts the default implementation class (CTNewArray2DRowsAndColumns) into a class method to provide a hook for subclasses. Removes hardcoded default implementation class from class methods not related to creating a specific implementation.
…ve unneeded new class method. This change makes use of the previously implemented hook to reuse generic instance creation methods from CTNewArray2D.
…ed width:height: class method. This change makes use of the previously implemented hook to reuse generic instance creation methods from CTNewArray2D.
This change adds the tabulate method, which allows to populate the fields of the CTNewArray. This change also refactors the CTNewArray2D class>>width:height:tabulate: to use the new method.
The previous example code was faulty and did not produce the same results on evaluation.
Pull Request Test Coverage Report for Build 8412687712Details
💛 - Coveralls |
|
Thanks this is cool to have another view on what we did. I was not really satisfied. |
|
@Enzo-Demeulenaere this may impact myg because there is no tag so may be we will have to just deprecate the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the class side methods of CTNewArray2D and its subclasses.