-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Phalcon v5 #1541
base: 5.0.x
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 5.0.x #1541 +/- ##
=====================================
Coverage 4.45% 4.45%
=====================================
Files 82 82
Lines 3995 3995
=====================================
Hits 178 178
Misses 3817 3817 |
How could I use your PR in my project? {
"repositories": [
{
"type":"package",
"package": {
"name": "rudiservo/phalcon-devtools",
"version":"5.0",
"source": {
"url": "https://github.com/rudiservo/phalcon-devtools.git",
"type": "git",
"reference":"5.0.x"
}
}
}
],
"require-dev": {
"rudiservo/phalcon-devtools": "5.0.x"
}
}
I also ran
|
hey, my file changes are minimal, the current phalcon/phalcon-devtools 5.0.x has the necessary PR for 5.0.x compatibility. the README in the project has the way to do it with git. |
Thanks for the reply. I can see the global is using phalcon/devtools 5.0.x-dev 2e16ea6 but when I run phalcon from the project's root folder, I get an error: Fatal error: Uncaught TypeError: strtolower(): Argument #1 ($string) must be of type string, bool given in /root/.composer/vendor/phalcon/devtools/bootstrap/autoload.php on line 40 Tried to fix with an
PS: It actually works if the project was created with devtools. Thanks for the help anyway. |
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Changelog and a link update to make official the support for phalcon v5
Thanks