The ext/json is always available since PHP 8.0 #16524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jeckerson to review @petk Please target 5.0.x branch. We don't commit directly to master. Thank you! |
The HAVE_JSON symbol is removed with PHP 8.4.0+ in php_config.h.
|
This is from Zephir side, will try check soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HAVE_JSON symbol is removed with PHP 8.4.0+.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
The HAVE_JSON symbol is removed with PHP 8.4.0+ in php_config.h. Perhaps fixing this can be done something like in the pull request, since the PHP 8.0 is the minimum required version for Phalcon since Phalcon 5.6.
Otherwise, PR needs to be adjusted further.
Thanks