Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in Router::handle() #16431

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix memory leak in Router::handle() #16431

merged 4 commits into from
Sep 11, 2023

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: bug fix | code quality

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Request service is picked for each route inside the routes cycle and is picked as shared service, which in some cases might contain previous request's information.

Thanks

@Jeckerson Jeckerson added enhancement Enhancement to the framework bug A bug report 5.0 The issues we want to solve in the 5.0 release labels Sep 11, 2023
@Jeckerson Jeckerson self-assigned this Sep 11, 2023
@Jeckerson Jeckerson merged commit 620e7a9 into 5.0.x Sep 11, 2023
38 checks passed
@Jeckerson Jeckerson deleted the router-memory-leak branch September 11, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeckerson @niden