Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16427 logger interpolation #16429

Merged
merged 3 commits into from
Sep 11, 2023
Merged

T16427 logger interpolation #16429

merged 3 commits into from
Sep 11, 2023

Conversation

niden
Copy link
Member

@niden niden commented Sep 11, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added interpolation tests for Logger

Thanks

@niden niden added enhancement Enhancement to the framework 5.0 The issues we want to solve in the 5.0 release labels Sep 11, 2023
@niden niden self-assigned this Sep 11, 2023
@niden niden merged commit 42c5a39 into phalcon:5.0.x Sep 11, 2023
38 checks passed
@niden niden deleted the T16427-logger-interpolation branch September 11, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson