Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix appimage support #112

Merged
merged 2 commits into from
May 31, 2024
Merged

fix appimage support #112

merged 2 commits into from
May 31, 2024

Conversation

theofficialgman
Copy link
Contributor

resolves #110

@theofficialgman
Copy link
Contributor Author

theofficialgman commented May 30, 2024

appimage type 1 is probably still broken but I don't readily have one of these available to test so am hesitant to add the binfmt for it
https://github.com/AppImage/AppImageSpec/blob/master/draft.md#type-1-image-format

it would be similar with x41\x49\x01 instead of x41\x49\x02

if you have one (arm32 or arm64) that you know is type 1 please link it and it can be tested with an appropriate additional binfmt.

@pguyot
Copy link
Owner

pguyot commented May 30, 2024

Thank you. Would you mind writing a test for these?

@theofficialgman theofficialgman force-pushed the upstream-main branch 2 times, most recently from 5afa4c7 to 08db896 Compare May 30, 2024 16:55
@theofficialgman
Copy link
Contributor Author

sorry my keyboard double presses keys sometimes. the commit name is spelled correctly now for the tests

@pguyot pguyot merged commit e1773de into pguyot:main May 31, 2024
97 checks passed
@pguyot
Copy link
Owner

pguyot commented May 31, 2024

Thank you. I pushed this as v2.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not run appimages
2 participants