Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get pull_spp() to work #127

Merged
merged 2 commits into from
Apr 29, 2024
Merged

get pull_spp() to work #127

merged 2 commits into from
Apr 29, 2024

Conversation

iantaylor-NOAA
Copy link
Contributor

The pull_spp() function wasn't working because the https://github.com/pfmc-assessments/nwfscSurvey/blob/main/data/PullSpp.rda file contained a PullSpp data frame, not pull_spp. If you prefer to rename the data frame or get this working some other way, we can delete this pull request.

In the bigger picture, is the goal for everyone to use the pull_*() functions in the future and deprecate the older Pull*.fn() versions? If so, more guidance on that in the vignette or function documentation could be helpful.

@chantelwetzel-noaa
Copy link
Contributor

The new pull request just merged into the main branch simplifies the code in that the older Pull* functions now call the newer pull_* function with a warning about the functions being deprecated. I don't recall why I did not choose to do that exact thing with the PullSpp.fn but I think I should modify it to be the same. In the pull_spp function it looks like I missed changing PullSpp to species in a place but there is also an issue with the species.rda file I created trying to mimic the PullSpp.rda.

@chantelwetzel-noaa chantelwetzel-noaa merged commit eb87609 into main Apr 29, 2024
8 checks passed
@chantelwetzel-noaa chantelwetzel-noaa deleted the fix-pull_spp branch April 29, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants