Footnotes: Remove extra callback when parsing content (WordPress#66370)

Co-authored-by: tyxla <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: mcsf <[email protected]>
pewresearch · Oct 23, 2024 · 609d573 · 609d573
1 parent 77f62e0
commit 609d573
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/packages/core-data/src/hooks/use-entity-block-editor.js b/packages/core-data/src/hooks/use-entity-block-editor.js
@@ -91,11 +91,6 @@ export default function useEntityBlockEditor( kind, name, { id: _id } = {} ) {
 		getEntityRecordEdits,
 	] );
 
-	const updateFootnotes = useCallback(
-		( _blocks ) => updateFootnotesFromMeta( _blocks, meta ),
-		[ meta ]
-	);
-
 	const onChange = useCallback(
 		( newBlocks, options ) => {
 			const noChange = blocks === newBlocks;
@@ -111,7 +106,7 @@ export default function useEntityBlockEditor( kind, name, { id: _id } = {} ) {
 				selection,
 				content: ( { blocks: blocksForSerialization = [] } ) =>
 					__unstableSerializeAndClean( blocksForSerialization ),
-				...updateFootnotes( newBlocks ),
+				...updateFootnotesFromMeta( newBlocks, meta ),
 			};
 
 			editEntityRecord( kind, name, id, edits, {
@@ -124,7 +119,7 @@ export default function useEntityBlockEditor( kind, name, { id: _id } = {} ) {
 			name,
 			id,
 			blocks,
-			updateFootnotes,
+			meta,
 			__unstableCreateUndoLevel,
 			editEntityRecord,
 		]
@@ -133,15 +128,15 @@ export default function useEntityBlockEditor( kind, name, { id: _id } = {} ) {
 	const onInput = useCallback(
 		( newBlocks, options ) => {
 			const { selection, ...rest } = options;
-			const footnotesChanges = updateFootnotes( newBlocks );
+			const footnotesChanges = updateFootnotesFromMeta( newBlocks, meta );
 			const edits = { selection, ...footnotesChanges };
 
 			editEntityRecord( kind, name, id, edits, {
 				isCached: true,
 				...rest,
 			} );
 		},
-		[ kind, name, id, updateFootnotes, editEntityRecord ]
+		[ kind, name, id, meta, editEntityRecord ]
 	);
 
 	return [ blocks, onInput, onChange ];