Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedBitSet<K = usize> where K: From<usize> + Into<usize> #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bestouff
Copy link

Here's a proof-of-concept. I've kept size arguments (in len(), with_capacity() and grow()) as usize to keep with the spirit of typed-index-collections and to be able to use it as a drop-in replacement for HashSet.
The only roadblock I have stumbled on is that new() still can be const for now.

@jrraymond
Copy link
Collaborator

Thanks for the contribution! I'll take a closer look later. Backwards compatibility is important so new no longer being const is definitely a blocker.

@bestouff
Copy link
Author

bestouff commented Nov 7, 2021

That's what I thought. It's probably better to wait that this particular issue is fixed. In the interim I made a separate crate (which is just a fork of yours with my PR applied): https://lib.rs/crates/tibitset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants