Do another general cleanup #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A call like diff(s, d, myEqualizer) can be replaced with diff(s, d, MyersDiff(myEqualizer)) which is definitely more clear on the intent.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
============================================
- Coverage 86.07% 85.96% -0.12%
+ Complexity 221 215 -6
============================================
Files 30 29 -1
Lines 632 627 -5
Branches 117 117
============================================
- Hits 544 539 -5
Misses 59 59
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lppedd
force-pushed
the
refactor/another-cleanup
branch
from
2df15c0 to
3a97e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly improves small things.
DiffRowGeneratorto allow passing a custom algorithm, instead of a custom equalizer onlyBeing I changed
DiffRowGenerator's constructor, and I removed adiff(...)overload, it would be better the next release be 0.7.0.