Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a read-only property for the current scene #145

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Add a read-only property for the current scene #145

merged 1 commit into from
Apr 16, 2018

Conversation

ianadeem
Copy link
Contributor

A getter for the current scene has been added to the screen object. This is required for handling screen resizes when the main loop is run manually by clients using draw_next_frame.

Tests are still passing.

Closes #144.

A getter for the current scene has been added to the screen object. This
is required for handling screen resizes when the main loop is run
manually by clients using draw_next_frame.
@stickler-ci
Copy link
Contributor

I couldn't find a .stickler.yml file in this repository. I can make one for you, or you can create one by following the documentation.

@coveralls
Copy link

coveralls commented Apr 16, 2018

Coverage Status

Coverage decreased (-0.05%) to 96.565% when pulling f2ff271 on ianadeem:current-screen-getter into 1cfabf9 on peterbrittain:master.

@peterbrittain peterbrittain merged commit d580f64 into peterbrittain:master Apr 16, 2018
@peterbrittain
Copy link
Owner

Thanks!

@ianadeem ianadeem deleted the current-screen-getter branch April 16, 2018 12:56
@ianadeem
Copy link
Contributor Author

My pleasure!
Do you have an ETA for when there might be a release with the fix?

@peterbrittain
Copy link
Owner

I was hoping to resolve #95 before creating a new release... Looks like the underlying issue is just sitting there, so maybe I'll submit my PR anyway and see whether that gets accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants