Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang format #565

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Clang format #565

merged 1 commit into from
Feb 26, 2020

Conversation

gilwoolee
Copy link
Contributor

Somehow I see bunch of clang format changes so I'm creating a PR to address this.
I'm on clang-format 6.0 so these seem to be correct?

Before creating a pull request

  • Document new methods and classes
  • Format code with make format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@aditya-vk
Copy link
Contributor

We can merge this but we do not have Travis setup for formatting checks.

@madan96 can you take this over [see #555 for the related issue]. I think the check was disabled during the shift to clang-6.0.

aditya-vk
aditya-vk approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@aditya-vk aditya-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilwoolee gilwoolee merged commit be60169 into master Feb 26, 2020
@gilwoolee gilwoolee deleted the gilwoo/clang branch February 26, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-vk aditya-vk aditya-vk approved these changes

@brianhou brianhou Awaiting requested review from brianhou

@egordon egordon Awaiting requested review from egordon egordon is a code owner

@yskim041 yskim041 Awaiting requested review from yskim041

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilwoolee @aditya-vk