Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-7 Run supervisor as pmm during build #3309

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 14, 2024

PMM-7

Link to the Feature Build: SUBMODULES-3770

This PR is meant to solve the problem we are currently seeing at build time, during the execution of the ansible dashboards role:

# supervisorctl stop grafana
"stdout": "grafana: ERROR (not running)"

# supervisorctl remove grafana
"stdout": "ERROR: process/group still running: grafana"

The problem is most probably due to the fact that we do not start supervisord as pmm, so it ends up being unable to stop a process owned by root. This leads to an eventual pipeline failure resulting in an interrupted build.

The issues is not reproducible in 100% of builds, but may still be affecting more than 50% of v3 builds.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (9369be0) to head (88fba9f).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3309      +/-   ##
==========================================
+ Coverage   43.50%   43.53%   +0.03%     
==========================================
  Files         366      366              
  Lines       44162    44162              
==========================================
+ Hits        19211    19228      +17     
+ Misses      23270    23254      -16     
+ Partials     1681     1680       -1     
Flag Coverage Δ
admin 11.47% <ø> (ø)
agent 51.96% <ø> (+0.12%) ⬆️
managed 45.25% <ø> (+0.01%) ⬆️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review November 14, 2024 19:28
@ademidoff ademidoff requested a review from a team as a code owner November 14, 2024 19:28
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team November 14, 2024 19:28
@ademidoff ademidoff merged commit 176a136 into v3 Nov 15, 2024
32 checks passed
@ademidoff ademidoff deleted the PMM-7-run-supervisor-as-pmm-at-build-time branch November 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants