Skip to content

PMM-12913 Migrate api endpoints to REST #6844

PMM-12913 Migrate api endpoints to REST

PMM-12913 Migrate api endpoints to REST #6844

Triggered via pull request March 22, 2024 22:36
Status Success
Total duration 8m 2s
Artifacts

main.yml

on: pull_request
Merge Gatekeeper
1m 49s
Merge Gatekeeper
Slack Notification success
5s
Slack Notification success
Slack Notification failure
0s
Slack Notification failure
Fit to window
Zoom out
Zoom in

Annotations

10 errors
Checks: agent/config/config_test.go#L156
string `--config-file=` has 6 occurrences, make it a constant (goconst)
Checks: managed/models/agent_helpers.go#L647
string `cannot use push_metrics_enabled with pmm_agent version=%q,` has 3 occurrences, make it a constant (goconst)
Checks: managed/models/agent_model.go#L444
string `.TextFiles.` has 5 occurrences, make it a constant (goconst)
Checks: managed/models/agent_helpers.go#L648
string ` it doesn't support it, minimum supported version=%q` has 3 occurrences, make it a constant (goconst)
Checks: managed/services/supervisord/supervisord.go#L537
string `.ini` has 3 occurrences, make it a constant (goconst)
Checks: managed/models/database_test.go#L284
string `INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, node_id, service_id, disabled, status, created_at, updated_at, tls, tls_skip_verify, max_query_length, query_examples_disabled, comments_parsing_disabled, max_query_log_size, table_count_tablestats_group_limit, rds_basic_metrics_disabled, rds_enhanced_metrics_disabled, push_metrics, expose_exporter) ` has 4 occurrences, make it a constant (goconst)
Checks: managed/models/database_test.go#L156
string `INSERT INTO services (service_id, service_type, service_name, node_id, environment, cluster, replication_set, address, port, socket, external_group, created_at, updated_at) ` has 5 occurrences, make it a constant (goconst)
Checks: managed/models/database_test.go#L77
string `INSERT INTO nodes (node_id, node_type, node_name, distro, node_model, az, address, created_at, updated_at) ` has 5 occurrences, make it a constant (goconst)
Checks: managed/models/database_test.go#L93
string `INSERT INTO nodes (node_id, node_type, node_name, machine_id, distro, node_model, az, address, created_at, updated_at) ` has 4 occurrences, make it a constant (goconst)
Checks: managed/models/database_test.go#L225
string `INSERT INTO agents (agent_id, agent_type, runs_on_node_id, pmm_agent_id, node_id, disabled, status, created_at, updated_at, tls, tls_skip_verify, max_query_length, query_examples_disabled, comments_parsing_disabled, max_query_log_size, table_count_tablestats_group_limit, rds_basic_metrics_disabled, rds_enhanced_metrics_disabled, push_metrics, expose_exporter) ` has 5 occurrences, make it a constant (goconst)