Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12971 Add pg exporter connection limit #750

Merged
merged 8 commits into from
May 28, 2024
Merged

PMM-12971 Add pg exporter connection limit #750

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
220fa2d
PMM-12971 Add pg exporter connection limit
YashSartanpara1 May 6, 2024
b902175
PMM-12971 Add check for azure pg
YashSartanpara1 May 7, 2024
e7c967e
PMM-12971 Update test cases for pg max connections
YashSartanpara1 May 7, 2024
49b9dd3
PMM-12971 Update pg max connection limit
YashSartanpara1 May 20, 2024
912d148
PMM-12971 Update default max connection logic
YashSartanpara1 May 21, 2024
f40197c
PMM-12971 Update test cases
YashSartanpara1 May 21, 2024
f116cb3
PMM-12971 fix validation and rds parameter
YashSartanpara1 May 24, 2024
142b957
PMM-12971 Fix logic for RDS
YashSartanpara1 May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions public/app/percona/add-instance/components/AddRemoteInstance/AddRemoteInstance.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export interface PostgreSQLPayload extends RemoteCommonPayload, TLSCommon {
agent_password: string;
max_query_length: number;
auto_discovery_limit: number;
max_exporter_connections: number;
}

export interface MySQLPayload extends RemoteCommonPayload, TLSCommon {
Expand Down Expand Up @@ -196,6 +197,7 @@ export interface RDSPayload extends CommonRDSAzurePayload {
metrics_mode: string;
qan_postgresql_pgstatements: boolean;
agent_password: string;
max_exporter_connections: number;
}

export interface MSAzurePayload extends CommonRDSAzurePayload {
Expand Down
3 changes: 3 additions & 0 deletions public/app/percona/add-instance/components/AddRemoteInstance/FormParts/FormParts.messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export const Messages = {
autoDiscovery: 'Auto-discovery',
autoDiscoveryLimit: 'Auto-discovery limit',
autoDiscoveryLimitOptions: 'State',
maxConnectionLimit: 'Maximum connection limit',
},
mysqlDetails: {
maxQueryLength: 'Max query length',
Expand Down Expand Up @@ -91,6 +92,7 @@ export const Messages = {
database: 'Database (default: postgres)',
maxQueryLength: 'Max query length',
autoDiscoveryLimit: 'Auto-discovery limit',
maxConnectionLimit: 'Maximum connection limit',
},
mysqlDetails: {
maxQueryLength: 'Max query length',
Expand Down Expand Up @@ -131,6 +133,7 @@ export const Messages = {
database: 'Database name',
maxQueryLength: 'Full Example (Fingerprint) storage is not allowed by default to have the best performance',
autoDiscoveryLimit: 'Turn off auto-discovery when the total count of databases exceeds the limit.',
maxConnectionLimit: 'Maximum number of connections to PostgreSQL instance that exporter can use',
},
mysqlDetails: {
maxQueryLength: 'Full Example (Fingerprint) storage is not allowed by default to have the best performance',
Expand Down
8 changes: 8 additions & 0 deletions ...s/AddRemoteInstance/FormParts/PostgreSQLConnectionDetails/PostgreSQLConnectionDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ export const PostgreSQLConnectionDetails: FC<MainDetailsFormPartProps> = ({ form
tooltipText={Messages.form.tooltips.postgresqlDetails.maxQueryLength}
/>
</div>
<div className={styles.group}>
matejkubinec marked this conversation as resolved.
Show resolved Hide resolved
<TextInputField
name="maxExporterConnections"
placeholder={Messages.form.placeholders.postgresqlDetails.maxConnectionLimit}
label={Messages.form.labels.postgresqlDetails.maxConnectionLimit}
tooltipText={Messages.form.tooltips.postgresqlDetails.maxConnectionLimit}
/>
</div>
</div>
);
};
Loading