Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12284 Remove alertmanager from settings #697

Merged
merged 3 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:

- name: Attaching artifacts
if: ${{ always() }}
uses: percona-platform/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: ui-tests-output
path: ./pmm-ui-tests/tests/output
13 changes: 0 additions & 13 deletions public/app/percona/settings/Settings.messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,6 @@ export const Messages = {
' about feature status',
technicalPreviewLinkText: 'here',
},
alertmanager: {
warningPre: "Note: integration with Alertmanager is needed only in cases when you can't use",
warningLinkContent: 'Percona Alerting',
warningPost: 'but you need to manage and configure alerts.',
action: 'Apply Alertmanager settings',
rulesLabel: 'Prometheus Alerting rules',
rulesLink: `https://per.co.na/alertmanager`,
rulesTooltip: 'Alerting rules in the YAML configuration format.',
urlLabel: 'Alertmanager URL',
urlLink: `https://per.co.na/alertmanager`,
urlTooltip: 'The URL of the external Alertmanager to use.',
},
diagnostics: {
action: 'Download server diagnostics',
label: 'Diagnostics',
Expand Down Expand Up @@ -96,7 +84,6 @@ export const Messages = {
metrics: 'Metrics Resolution',
advanced: 'Advanced Settings',
ssh: 'SSH Key',
alertManager: 'Alertmanager Integration',
perconaPlatform: 'Percona Platform',
communication: 'Communication',
},
Expand Down

This file was deleted.

This file was deleted.

146 changes: 0 additions & 146 deletions public/app/percona/settings/components/AlertManager/AlertManager.tsx

This file was deleted.

1 change: 0 additions & 1 deletion public/app/percona/settings/components/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export { Advanced } from './Advanced/Advanced';
export { AlertManager } from './AlertManager/AlertManager';
export { Diagnostics } from './Diagnostics/Diagnostics';
export { MetricsResolution } from './MetricsResolution/MetricsResolution';
export { SSHKey } from './SSHKey/SSHKey';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,6 @@ export const getPmmSettingsPage = (alertingEnabled = false): NavModelItem => {
text: 'SSH Key',
url: `${config.appSubUrl}/settings/ssh-key`,
},
{
id: 'settings-alert-manager',
text: 'Alertmanager Integration',
url: `${config.appSubUrl}/settings/am-integration`,
},
{
id: 'settings-percona-platform',
text: 'Percona Platform',
Expand Down
9 changes: 0 additions & 9 deletions public/app/routes/routes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -694,15 +694,6 @@ export function getAppRoutes(): RouteDescriptor[] {
() => import(/* webpackChunkName: "SSHKeySettingsPage" */ 'app/percona/settings/components/SSHKey/SSHKey')
),
},
{
path: '/settings/am-integration',
component: SafeDynamicImport(
() =>
import(
/* webpackChunkName: "AMIntegrationSettingsPage" */ 'app/percona/settings/components/AlertManager/AlertManager'
)
),
},
{
path: '/settings/percona-platform',
component: SafeDynamicImport(
Expand Down
Loading