PMM-12608 Add auto discovery limit for PG #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejkubinec
commented
Nov 1, 2023
public/app/percona/add-instance/components/AddRemoteInstance/FormParts/FormParts.messages.ts
Outdated
Show resolved
Hide resolved
1 task
YashSartanpara1
approved these changes
Nov 6, 2023
.../add-instance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.tsx
Outdated
Show resolved
Hide resolved
.../add-instance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.tsx
Outdated
Show resolved
Hide resolved
doracretu3pillar
approved these changes
Nov 6, 2023
doracretu3pillar
approved these changes
Nov 6, 2023
YashSartanpara1
pushed a commit
that referenced
this pull request
Jan 24, 2024
* PMM-12608 Add auto discovery limit for PG * PMM-12608 Adjust stat tracking styling * PMM-12608 Fix custom value setting * PMM-12608 Remove tooltip from autodiscovery * PMM-12608 Address comments * PMM-12608 Use enabled instead of disabled & tooltips * PMM-12608 Match validation to table stats + fix table stats * PMM-12608 Set default custom autodiscovery limit to 10 * PMM-12608 Add integer validation * PMM-12608 Add option to disable autodiscovery * PMM-12608 Fix unit tests
BupycHuk
pushed a commit
that referenced
this pull request
Jan 31, 2024
* PMM-12544 Add deprecation notice for DBaaS (#692) * PMM-12544 Add deprecation notice for DBaaS * PMM-12544 Remove K8s promotion message * PMM-12544 Removed unnecessary unit test * PMM-12608 Add auto discovery limit for PG (#695) * PMM-12608 Add auto discovery limit for PG * PMM-12608 Adjust stat tracking styling * PMM-12608 Fix custom value setting * PMM-12608 Remove tooltip from autodiscovery * PMM-12608 Address comments * PMM-12608 Use enabled instead of disabled & tooltips * PMM-12608 Match validation to table stats + fix table stats * PMM-12608 Set default custom autodiscovery limit to 10 * PMM-12608 Add integer validation * PMM-12608 Add option to disable autodiscovery * PMM-12608 Fix unit tests * PMM-12709 Set default autodiscovery limit to 10 (#699) * PMM-12459: PMM Dump Integration - Phase1 (#694) * PMM Export page - draft * PMM Dump table and mocked date * Fixes after review + TimeRange * Download, Delete and SendToSupport items created * Send to Support without API call * Removed download, added delete partial functionality * PMM-12504 add export dataset page * PMM-12504 link to export dataset page * PMM-12504 fix overflow * Show the nodes names instead of nodes ids * Update .betterer.results * PMM-12507 add pmm dump logs modal * PMM-12504 fix timepicker * PMM-12504 fix type * PMM-12504 fix types * PMM-12504 add export dump services * PMM-12507 Move logs button * Removed mocked methods * Links delete to an api * Fixed Breadcrumb * PMM-12459 add multiselect * PMM-12504 use service name for dump * Pull api once at 5 seconds * Use Service Names instead of Node Ids * Send to Support call to API * PMM-12504 add alert for invalid date range * Refactor after review * PMM-12504 Fix according to review * PMM-12504 add getlogs action * Changed Status names * PMM-12459 Add pmm dump into PerconaNavigation * Show error/successful messages for ftp upload * Use withAppEvents in order to show the successMessage * Disable notifications coming from api * Updated logs api request * Changed the FTP parameters * Added a new input, directory ,to ftp upload * PMM-12504 move labels to Messages * Update according to review * Added download functionality * PMM-12459 Update default time range * Download file fixed * PMM-12459 fix logs viewer * Disable download for non successful created dumps * Reused link constant * Fixed typo * PMM-12459 update labels * Make directory optional * Disable delete button when downloading * PMM-12459 Send empty array for all services * added isDeleting flag and increased the interval for downloading * PMM-12459 Fix CI --------- Co-authored-by: Yash Sartanpara <[email protected]> Co-authored-by: Yash Sartanpara <[email protected]> Co-authored-by: “dorac-ext” <[email protected]> Co-authored-by: Artem Gavrilov <[email protected]> * PMM-12476 Cluster view search (#687) * PMM-12476 Add clusters search and filtering * PMM-12476 Use correct type * PMM-12476 Cleanup * PMM-12476 Remove logging and dead code * PMM-12476 Allow actions dialog to be visible * PMM-12443: filter for backups (#685) * Added Filter for All Backups table * Added filter for Restore, ScheduledBackups and StorageLocations * Filters for StorageLocation, RestoreHistory and BackupInventory * Fixed UI tests * Fixed lint * Fixed test * PMM-12545 Remove dbaas ui * PMM-12545 fix import for dump * PMM-12545 restore warning and remove comments * PMM-12545 remove dbaas deprecation warning --------- Co-authored-by: Matej Kubinec <[email protected]> Co-authored-by: Dora <[email protected]> Co-authored-by: “dorac-ext” <[email protected]> Co-authored-by: Artem Gavrilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new field for handling PG auto discovery limit. Missing is the text for the tooltip.
Which issue(s) this PR fixes:
PMM-12608
FB: Percona-Lab/pmm-submodules#3424
Special notes for your reviewer: