-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Fingerprint fi overflow cause index out of range panic #30
base: master
Are you sure you want to change the base?
Conversation
martianzhang
commented
Mar 29, 2018
•
edited
Loading
edited
sql: insert into tb values (1) Fingerprint(sql) got panic: index out of range
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
- Coverage 63.91% 63.82% -0.1%
=========================================
Files 8 8
Lines 1416 1418 +2
=========================================
Hits 905 905
- Misses 400 401 +1
- Partials 111 112 +1
Continue to review full report at Codecov.
|
Merge new update
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 67.02% 67.07% +0.04%
==========================================
Files 7 7
Lines 1389 1391 +2
==========================================
+ Hits 931 933 +2
Misses 348 348
Partials 110 110
Continue to review full report at Codecov.
|
Thanks for contributing @martianzhang! Let us check this and get back to you soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the code change, the tests are passing anyways.
I don't think we need to merge this.
In order to accept this change, I would like to see a failing case.
@percona-csalguero I update the test case, no space between |