minifront: modify sync modal #1976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60f4d35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
VanishMax
approved these changes
Jan 8, 2025
agreed, I'll hold off merging for now until we can discuss more next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
prompts the user to keep the extension open during the initial sync since syncing is faster, and removes the "estimated time remaining" which is highly inaccurate and drastically fluctuates when syncing congested blocks or on slower internet connections. I'd argue the sync percentage is a sufficient indicator of syncing progress (and the syncing bar at the top of Minifront already displays the estimated time remaining), but open to reviewers opinions.
before
after
Related Issue
references #1961
Checklist Before Requesting Review