Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mobile styles for positions block #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: mobile styles for positions block #298

wants to merge 1 commit into from

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Jan 20, 2025 •
edited
Loading

Right now, DEX on mobile is overly stretched (965px for 375px-mobile screen, see screenshot), which causes bugs to all other blocks like summary and chart. This PR fixes it by adding correct overflow.

Before:

image

@VanishMax VanishMax requested a review from a team January 20, 2025 11:41
@VanishMax VanishMax self-assigned this Jan 20, 2025
TalDerei
TalDerei reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@TalDerei TalDerei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the mobile rendering (responsive mode) i'm currently seeing

Screen.Recording.2025-01-20.at.1.32.16.PM.mov

@TalDerei
Copy link
Contributor

@VanishMax any updates with the rendering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@VanishMax VanishMax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VanishMax @TalDerei