Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKLOG-43190] License fails to load when opening PSW from outside i… #1448

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[BACKLOG-43190] License fails to load when opening PSW from outside i… #1448

merged 1 commit into from
Jan 22, 2025

Conversation

singletonc
Copy link
Contributor

…ts root directory

  • Add LICENSE.TXT to classpath so it can be found on any OS regardless of where the program is started from

@singletonc singletonc requested a review from a team as a code owner January 21, 2025 22:50
@buildguy

This comment has been minimized.

Sign in to view
@rmansoor
Copy link
Contributor

@angel-ramoscardona Please review as well

@singletonc
[BACKLOG-43190] License fails to load when opening PSW from outside i…
8219991 
…ts root directory

- Add LICENSE.TXT to classpath so it can be found on any OS regardless of where the program is started from
@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@buildguy
Copy link
Collaborator

✅ Build finished in 2m 24s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -DrunITs -pl \
assemblies/psw-ce,workbench

❗ No tests found!

ℹ️ This is an automatic message

@hitachivantarasonarqube HitachiVantaraSonarQube
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.60% Estimated after merge)

Project ID: pentaho:pentaho-mondrian-parent-pom

View in SonarQube

@singletonc
Copy link
Contributor Author

singletonc commented Jan 22, 2025 •
edited
Loading

Fixed the build issue caused by removing SimpleDateFormat import (added it back). My mondrian project in IDEA is messed up.

@NJtwentyone NJtwentyone merged commit 98441a4 into pentaho:master Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NJtwentyone NJtwentyone NJtwentyone approved these changes

@rmansoor rmansoor rmansoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singletonc @buildguy @rmansoor @NJtwentyone