Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type safety and type hinting #317

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
+2,428 −2,185

🚿 clean up type aliases more

5232436
Select commit
Loading
Failed to load commit list.
Open

Add type safety and type hinting #317

🚿 clean up type aliases more
5232436
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 14, 2024 in 1s

90.91% (+0.08%) compared to 44965e9

View this Pull Request on Codecov

90.91% (+0.08%) compared to 44965e9

Details

Codecov Report

Attention: Patch coverage is 94.57112% with 50 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (44965e9) to head (5232436).

Files with missing lines Patch % Lines
backend/sublet/views.py 86.90% 11 Missing ⚠️
backend/pennmobile/admin.py 50.00% 7 Missing ⚠️
backend/portal/permissions.py 84.21% 6 Missing ⚠️
backend/sublet/serializers.py 90.90% 5 Missing ⚠️
...nndata/management/commands/get_fitness_snapshot.py 63.63% 4 Missing ⚠️
backend/gsr_booking/admin.py 70.00% 3 Missing ⚠️
backend/gsr_booking/models.py 94.91% 3 Missing ⚠️
backend/gsr_booking/api_wrapper.py 96.55% 2 Missing ⚠️
backend/utils/email.py 81.81% 2 Missing ⚠️
backend/dining/api_wrapper.py 90.90% 1 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   90.83%   90.91%   +0.08%     
==========================================
  Files          63       64       +1     
  Lines        2629     2851     +222     
==========================================
+ Hits         2388     2592     +204     
- Misses        241      259      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov