Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Laundry Rewrite to Account For New SpeedQueen API #308

Merged
merged 13 commits into from
Nov 17, 2024

Merge branch 'master' of github.com:pennlabs/penn-mobile into fix/lau…

c5ad053
Select commit
Loading
Failed to load commit list.
Merged

[Fix] Laundry Rewrite to Account For New SpeedQueen API #308

Merge branch 'master' of github.com:pennlabs/penn-mobile into fix/lau…
c5ad053
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 17, 2024 in 0s

89.60% (-0.64%) compared to d1044c2

View this Pull Request on Codecov

89.60% (-0.64%) compared to d1044c2

Details

Codecov Report

Attention: Patch coverage is 78.26087% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.60%. Comparing base (d1044c2) to head (c5ad053).

Files with missing lines Patch % Lines
backend/laundry/api_wrapper.py 69.44% 11 Missing ⚠️
...aundry/management/commands/update_laundry_rooms.py 75.00% 6 Missing ⚠️
backend/laundry/views.py 84.21% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   90.23%   89.60%   -0.64%     
==========================================
  Files          66       67       +1     
  Lines        2684     2704      +20     
==========================================
+ Hits         2422     2423       +1     
- Misses        262      281      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov