Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Laundry Rewrite to Account For New SpeedQueen API #308

Merged
merged 13 commits into from
Nov 17, 2024

Merge branch 'master' of github.com:pennlabs/penn-mobile into fix/lau…

0663073
Select commit
Loading
Failed to load commit list.
Merged

[Fix] Laundry Rewrite to Account For New SpeedQueen API #308

Merge branch 'master' of github.com:pennlabs/penn-mobile into fix/lau…
0663073
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 17, 2024 in 1s

90.16% (-0.67%) compared to 44965e9

View this Pull Request on Codecov

90.16% (-0.67%) compared to 44965e9

Details

Codecov Report

Attention: Patch coverage is 77.89474% with 21 lines in your changes missing coverage. Please review.

Project coverage is 90.16%. Comparing base (44965e9) to head (0663073).

Files with missing lines Patch % Lines
backend/laundry/api_wrapper.py 64.70% 12 Missing ⚠️
...aundry/management/commands/update_laundry_rooms.py 80.64% 6 Missing ⚠️
backend/laundry/views.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   90.83%   90.16%   -0.67%     
==========================================
  Files          63       64       +1     
  Lines        2629     2654      +25     
==========================================
+ Hits         2388     2393       +5     
- Misses        241      261      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.