Fix libcal booking #247
Fix libcal booking #247
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
=======================================
Coverage 91.38% 91.39%
=======================================
Files 59 59
Lines 2496 2510 +14
=======================================
+ Hits 2281 2294 +13
- Misses 215 216 +1 ☔ View full report in Codecov by Sentry. |
| in_use = models.BooleanField(default=True) | ||
|
|
||
| objects = GSRManager() | ||
| all_objects = models.Manager() # for admin page |
There was a problem hiding this comment.
that is great, thanks vincent! @tuneerroy @ashleyzhang01 @JeffersonDing @dr-Jess just for reference look at this man!
| self.assertEquals(6, len(res_json[0])) | ||
| self.assertEquals(6, len(res_json[1])) | ||
| self.assertEquals(7, len(res_json[0])) | ||
| self.assertEquals(7, len(res_json[1])) |
There was a problem hiding this comment.
i'm imagining that the extra field is the in_use? any reason it still shows up in the route despite all of our queries using .object to query? if this is the case, I think we should remove this field from showing up
There was a problem hiding this comment.
oh the serializer was still serializing all the fields. fixed now
No description provided.