Fix non-admin case

pennlabs · Nov 11, 2024 · 8867434 · 8867434
1 parent c6861cc
commit 8867434
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/backend/clubs/serializers.py b/backend/clubs/serializers.py
@@ -2987,7 +2987,10 @@ def get_approved_by(self, obj):
         if not user.is_authenticated:
             return None
         if not user.has_perm("clubs.see_pending_clubs"):
-            return None
+            club = Club.objects.get(code=obj.code)
+            membership = Membership.objects.filter(person=user, club=club).first()
+            if membership is None or membership.role < Membership.ROLE_OFFICER:
+                return None
         if obj.approved_by is None:
             return "Unknown"
         return obj.approved_by.get_full_name()

diff --git a/frontend/components/ClubPage/ClubApprovalDialog.tsx b/frontend/components/ClubPage/ClubApprovalDialog.tsx
@@ -164,7 +164,9 @@ const ClubApprovalDialog = ({ club }: Props): ReactElement | null => {
       doApiRequest('/templates/?format=json')
         .then((resp) => resp.json())
         .then(setTemplates)
+    }
 
+    if (isOfficer || canApprove) {
       doApiRequest(`/clubs/${club.code}/history/?format=json`)
         .then((resp) => resp.json())
         .then((data) => {
@@ -182,6 +184,7 @@ const ClubApprovalDialog = ({ club }: Props): ReactElement | null => {
           setHistory(lastVersions)
         })
     }
+
     setComment(
       selectedTemplates.map((template) => template.content).join('\n\n'),
     )