Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated linter fix - (Built on django-migrate and NOT main) #312

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

benjmnxu
Copy link
Contributor

@benjmnxu benjmnxu commented Apr 14, 2024

Restore backend checks for ohq deployment.

  • Black
  • Flake
  • No Ruff (idk what this is)
  • Backend test cases (which we haven't run in like two years lmao)
  • No Codecoverage. Uses an outdated django.yaml (We need to add codecoverage token into our secrets)

@benjmnxu benjmnxu changed the base branch from master to django-migrate April 14, 2024 19:44
@benjmnxu benjmnxu changed the title Migrated linter fix - (Built on Migrated Branch and NOT main) Migrated linter fix - (Built on django-migrate and NOT main) Apr 14, 2024
Copy link
Member

@judtinzhang judtinzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Can you please take a look at penn-mobile's configs and see if playing with those helps anything (ex. codecov)? Let me know the results!

.github/workflows/shared-build-deploy.yaml Show resolved Hide resolved
.github/workflows/shared-build-deploy.yaml Show resolved Hide resolved
@benjmnxu
Copy link
Contributor Author

Main issue with codecov is just the token I believe. Error message on running codecov:

'Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.'

If the upload token is shared I'll keep looking into it. If it's ohq specific, I'll need to ask Bach or Dan to add it into our secrets

@judtinzhang
Copy link
Member

Makes sense, lmk if you stumble into anything else

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (django-migrate@27f57fc). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             django-migrate     #312   +/-   ##
=================================================
  Coverage                  ?   98.93%           
=================================================
  Files                     ?       25           
  Lines                     ?     1316           
  Branches                  ?        0           
=================================================
  Hits                      ?     1302           
  Misses                    ?       14           
  Partials                  ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjmnxu
Copy link
Contributor Author

benjmnxu commented Apr 21, 2024

Codecov token added. All tests pass.

@judtinzhang judtinzhang self-requested a review April 21, 2024 18:39
Base automatically changed from django-migrate to master September 13, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants