Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat instance retrieving in syncHistory #3342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alechkos
Copy link
Collaborator

@alechkos alechkos commented Oct 18, 2024

PR Details

The PR fixes the invalid logic of chat instance retrieving in Client.syncHistory:

const chat = await window.WWebJS.getChat(chatId);

We don't want to get a serialized chat model.

How Has This Been Tested

// client initialization...

client.on('ready', async () => {
    const chatId = 'YOUR_CHAT_ID_HERE';
    console.log(await client.syncHistory(chatId));
}

You can try the fix by running one of the following commands:

  • NPM
npm install github:alechkos/whatsapp-web.js#fix-sync-history
  • YARN
yarn add github:alechkos/whatsapp-web.js#fix-sync-history

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).
  • I have updated the usage example accordingly (example.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant