Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pre_install/post_install receiving a generator not a list #3191

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

PKilcommons
Copy link
Contributor

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixes #3190

I wasn't so sure about where it made the most sense to put the regression tests so let me know if there's a more sensible place for them, or if you have a better idea for how they should be written.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (d579492) to head (fdfe3dd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3191   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files         112      112           
  Lines       11213    11213           
  Branches     2432     2432           
=======================================
  Hits         9602     9602           
  Misses       1098     1098           
  Partials      513      513           
Flag Coverage Δ
unittests 85.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 8dc3ae7 into pdm-project:main Sep 29, 2024
24 checks passed
@frostming
Copy link
Collaborator

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages parameter for the pre_install and post_install hooks is given as an exhausted generator
2 participants