Enable Tsys multipass Payment Gateway #1
Conversation
…chant into enable-tsys-multipass
rahuldess
changed the title
| (parsed_body.present? && parsed_body.first[1]) || EMPTY_OBJ | ||
| end | ||
|
|
||
| def parse(body) |
There was a problem hiding this comment.
I took a look at the active_merchant and I noticed that other gateways are parsing JSON just like you're doing. I'd probably recommend isolating this and make a global helper for the gem.
Some examples:
https://github.com/activemerchant/active_merchant/blob/master/lib/active_merchant/billing/gateways/adyen.rb#L443
https://github.com/activemerchant/active_merchant/blob/master/lib/active_merchant/billing/gateways/balanced.rb#L211
It isn't a mandatory change. It's a nice to have but I believe that'd be a plus for this gem if we have a Parser object that is able to parse JSON, XML and CGI. These are the ones that I saw. I'd start with JSON.
There was a problem hiding this comment.
Parser might require some good thought on how to handle it generic-ly. Each gateway file want's to handle their parsing in its own specific way.. Considering it ill leave it for now.
rahuldess
force-pushed
the
enable-tsys-multipass
branch
from
c77dd68 to
6d098b3
Compare
* Adding Tsys Multipass to ActiveMerchant * enabling verify * Adding Tsys Multipass to ActiveMerchant * enabling verify * unit specs * adding specs * fixing * fixing fixtures order spec * fixing rubocop issues
Enabling Tsys Multipass payment gateway in ActiveMerchant gem.
FYI, ActiveMerchant's Source PR: activemerchant#3469