Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8 attributes support #15

Merged
merged 15 commits into from
Sep 11, 2024

Conversation

fiveight00
Copy link
Contributor

No description provided.

@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch 4 times, most recently from 82479ec to dbb65ba Compare April 26, 2024 06:37
@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch 2 times, most recently from 3c049ff to 3385620 Compare April 26, 2024 08:25
@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch 3 times, most recently from ff18d46 to 3b5d5e5 Compare April 26, 2024 08:56
src/Service/RoutingLoader/RoutingAttributeLoader.php Outdated Show resolved Hide resolved
src/Annotation/RestAnnotationInterface.php Outdated Show resolved Hide resolved
src/Attribute/Body.php Outdated Show resolved Hide resolved
src/Attribute/Body.php Outdated Show resolved Hide resolved
src/Attribute/RestAttributeInterface.php Outdated Show resolved Hide resolved
src/Attribute/Validation.php Outdated Show resolved Hide resolved
src/Attribute/Validation.php Outdated Show resolved Hide resolved
@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch from 748dba8 to b64b8a6 Compare June 10, 2024 08:57
@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch from b64b8a6 to fc39861 Compare June 10, 2024 08:59
@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch 2 times, most recently from aef1c7c to ad929c3 Compare June 10, 2024 09:31
@fiveight00 fiveight00 force-pushed the add-php-8-attributes-support branch from ad929c3 to 191b540 Compare June 10, 2024 09:37
@borilyordanov
Copy link
Contributor

Perhaps we should adjust the examples in the README file to include not only annotations but also attributes. What do you think?

src/Service/Annotation/ReflectionMethodWrapper.php Outdated Show resolved Hide resolved
src/Attribute/ResponseNormalization.php Outdated Show resolved Hide resolved
src/Service/Annotation/ReflectionMethodWrapper.php Outdated Show resolved Hide resolved
src/Attribute/Body.php Outdated Show resolved Hide resolved
Copy link
Contributor

@borilyordanov borilyordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borilyordanov borilyordanov merged commit dc7601c into paysera:master Sep 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants