fix(ui): updatedAt field in locked-docs collection able to be updated by non-owner
#9026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikKozak
changed the title
updatedAt field in payload-locked-docs able to updated by non-ownerupdatedAt field in payload-locked-docs able to be updated by non-owner
PatrikKozak
changed the title
updatedAt field in payload-locked-docs able to be updated by non-ownerupdatedAt field in locked-docs collection able to be updated by non-owner
DanRibbens
approved these changes
Nov 5, 2024
|
🚀 This is included in version v3.0.0-beta.125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If you have a custom field that sets the value of the field using the
useFieldhook on entry into a document - theupdatedAtfield would be updated even when a non-owner tries to enter a locked document.Why?
When a field is updated in the edit view - we perform an update in
form-stateto keep the doc inpayload-locked-documentsup to date with the current editing status. The above scenario would hit this update operation even on non-owner users because it was previously only checking forupdateLastEdited(which would get hit by thesetValuein theuseFieldhook) so we also need to check to make sure the current user entering a locked doc is also the owner of the document.How?
When performing an update to
payload-locked-documentsinbuildFormState- only perform the update if the current user is also the owner of the locked document otherwise skip theupdateoperation.Fixes #8781