Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-mongodb): id in querying with an aggregation using a comma-delimited value #8910

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

r1tsuu
Copy link
Member

@r1tsuu r1tsuu commented Oct 28, 2024

What?

Fixes the issue with in querying when the collection has a join field.

Why?

When using .aggregate, MongoDB doesn't cast a comma delimited value for the $in operator to an array automatically as it's not handled by Mongoose.

How?

Sanitizes the incoming value to an array if it should.

Fixes #8901

@r1tsuu r1tsuu changed the title Fix/join field in querying fix(db-mongodb): id in querying using a comma-delimited value Oct 28, 2024
@r1tsuu r1tsuu marked this pull request as ready for review October 28, 2024 21:34
@r1tsuu r1tsuu changed the title fix(db-mongodb): id in querying using a comma-delimited value fix(db-mongodb): id in querying with an aggregation using a comma-delimited value Oct 28, 2024
@DanRibbens DanRibbens merged commit 7a7a2f3 into beta Oct 28, 2024
61 of 62 checks passed
@DanRibbens DanRibbens deleted the fix/join-field-in-querying branch October 28, 2024 23:41
Copy link

🚀 This is included in version v3.0.0-beta.120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join field cannot query more than 1 doc with [in] operator using mongodb
2 participants