fix: redirect to inactivity route after inactivity logout #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the auth token expired, the user object was set to null, but the UI was left unchanged, leading to errors when the user tried to perform actions. Now the user is redirected to the innactivity route saying that they have been logged out.
This prevents a couple of logout requests when the user is already logged out and is redirected to the inactivity route (logout page).
franciscolourenco
force-pushed
the
fix/innactivity-logout-redirect
branch
from
dee1d8d
to
a09e97b
Compare
| @@ -18,7 +18,8 @@ export const LogoutClient: React.FC<{ | |||
| }> = (props) => { | |||
| const { adminRoute, inactivity, redirect } = props | |||
|
|
|||
| const [isLoggedOut, setIsLoggedOut] = React.useState<boolean | undefined>(undefined) | |||
| const { logOut, user } = useAuth() | |||
| const [isLoggedOut, setIsLoggedOut] = React.useState<boolean>(!user) | |||
There was a problem hiding this comment.
This is just to prevent logout requests with errors when the user is redirected after already being logged out.
JarrodMFlesch
changed the title
franciscolourenco
changed the title
franciscolourenco
changed the title
|
I'm working on this alongside this issue: #5009 |
|
I ended up folding your changes here into the same PR. #9070 |
|
Sure thing @kendelljoseph, shall I close this one then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the auth token expired, the user object was set to
null, but the UI was left unchanged, leading to errors when the user tried to interact with the UI.With this PR, the user is redirected to the inactivity route saying that they have been logged out.
Follow up to #8600
With 5 seconds expiration time:
Screen.Recording.2024-10-21.at.18.38.39.mp4