fix(ui): unique ids for nested rows on row duplicate to prevent errors with postgres #8790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRibbens
requested changes
Oct 19, 2024
There was a problem hiding this comment.
It would be a quick e2e test to add considering we already have the config in place to support it.
In test/fields/e2e.spec.ts
Go to create block-fields
Duplicate the first block with sub blocks
Save and assert
This assumes we run e2e using postgres or SQLite which we don't currently in CI but we should reconsider that. For now running tests locally is good.
DanRibbens
approved these changes
Oct 21, 2024
DanRibbens
deleted the
fix/duplicate-blocks-and-blocks-inside-of-blocks-duplicate
branch
|
🚀 This is included in version v3.0.0-beta.117 |
DanRibbens
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8784
This works for any deep level, both arrays and blocks.