Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: corrects block duplicate action and add tests #6589

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix: corrects block duplicate action and add tests #6589

merged 1 commit into from
Jun 12, 2024

Conversation

JessChowdhury
Copy link
Member

Description

Closes #6401

Duplicating a block creates 2 new block copies (should be 1) and duplicating the last block crashes the admin panel.

This change fixes the duplicate action in Form > fieldReducer.ts and adds e2e test for block duplicating.

NOTE: Need to enable reactStrictMode: true in the next.config to replicate this issue.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works

@JessChowdhury JessChowdhury mentioned this pull request May 31, 2024
Closed
@JarrodMFlesch JarrodMFlesch merged commit 763a34f into beta Jun 12, 2024
45 checks passed
@JarrodMFlesch JarrodMFlesch deleted the fix/duplicate-block-bug branch June 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarrodMFlesch JarrodMFlesch Awaiting requested review from JarrodMFlesch

Assignees
No one assigned
Labels
created-by: Payload team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JessChowdhury @JarrodMFlesch