Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(richtext-*): fix client features were not loaded properly, improve performance of LexicalProvider, slate cell component was non-functional, support richtext adapter Cell RSCs #6573

Merged
merged 8 commits into from
May 30, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented May 30, 2024

Description

schemaPath in the Cell components of richText was empty, as it was not passed through useFieldProps there. Moved it to cellComponentProps. Now that the clientFeature/componentMap paths have proper schemaPaths again, stuff is working again.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@AlessioGr AlessioGr changed the title fix(richtext-lexical): client features were not loaded properly, improve performance of LexicalProvider fix(richtext-lexical): client features were not loaded properly, improve performance of LexicalProvider, slate cell component was non-functional, support richtext adapter Cell RSCs May 30, 2024
@AlessioGr AlessioGr changed the title fix(richtext-lexical): client features were not loaded properly, improve performance of LexicalProvider, slate cell component was non-functional, support richtext adapter Cell RSCs feat(richtext-lexical): fix client features were not loaded properly, improve performance of LexicalProvider, slate cell component was non-functional, support richtext adapter Cell RSCs May 30, 2024
@AlessioGr AlessioGr changed the title feat(richtext-lexical): fix client features were not loaded properly, improve performance of LexicalProvider, slate cell component was non-functional, support richtext adapter Cell RSCs fix(richtext-*): fix client features were not loaded properly, improve performance of LexicalProvider, slate cell component was non-functional, support richtext adapter Cell RSCs May 30, 2024
@AlessioGr AlessioGr merged commit 5cb49c3 into beta May 30, 2024
43 checks passed
@AlessioGr AlessioGr deleted the fix/lexical-cell branch May 30, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant