Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(richtext-lexical)!: configurable fixed toolbar #6560

Merged
merged 13 commits into from
May 30, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented May 29, 2024

Description

No sauron toolbar by default anymore. Uses scroll events to make sure only one toolbar is sticky at the same time

CleanShot.2024-05-29.at.16.24.24.mp4

BREAKING: useEditorFocusProvider has been removed and merged with useEditorConfigContext. You can now find information about the focused editor, parent editors and child editors within useEditorConfigContext

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@AlessioGr AlessioGr changed the title feat(richtext-lexical): fixed toolbar which makes james happy feat(richtext-lexical): configurable fixed toolbar May 29, 2024
@AlessioGr AlessioGr marked this pull request as draft May 29, 2024 17:58
@AlessioGr AlessioGr marked this pull request as ready for review May 29, 2024 20:24
@AlessioGr AlessioGr requested a review from denolfe as a code owner May 30, 2024 14:55
@AlessioGr AlessioGr changed the title feat(richtext-lexical): configurable fixed toolbar feat(richtext-lexical)!: configurable fixed toolbar May 30, 2024
@AlessioGr AlessioGr enabled auto-merge (squash) May 30, 2024 15:08
@AlessioGr AlessioGr merged commit f41bb05 into beta May 30, 2024
43 checks passed
@AlessioGr AlessioGr deleted the lexical/fixed-toolbar-config branch May 30, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant