chore: add int test: should not duplicate block rows for blocks within localized array fields #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-dom versions to match exactly what Next.js is using, various dependency cleanup (#7106) **BREAKING:** - Upgrades minimum supported @types/react version from npm:[email protected] to npm:[email protected] - Upgrades minimum supported @types/react-dom version from npm:[email protected] to npm:[email protected] - Upgrades minimum supported react and react-dom version from 19.0.0-rc-f994737d14-20240522 to 19.0.0-rc-6230622a1a-20240610
…n-test and jest/prefer-strict-equal
…t node types, remove SerializedBlockNode from default node types
## Description Improves the status pill in the version archive and version comparison views. - [X] I have read and understand the [CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md) document in this repository. ## Type of change - [X] New feature (non-breaking change which adds functionality) ## Checklist: - [X] Existing test suite passes locally with my changes
Email adapter warnings are triggered on production builds. The `NEXT_PHASE` env var is now evaluated before logging this warning.
- Improves color contrast of various components in the admin panel. - Adjusts placement of field error tooltips for consistency. - Corrects misaligned modals. - Fixes issue where `admin.layout: vertical` was not being applied to `radio` fields.
We now validate the names of the field against an array of protected field names. Also added JSDoc since we can't enforce type strictness yet if `string | const[]` as it always evaluates to `string`. ``` The name of the field. Must be alphanumeric and cannot contain ' . ' Must not be one of protected field names: ['__v', 'salt', 'hash', 'file'] @link — [https://payloadcms.com/docs/fields/overview#field-names](vscode-file://vscode-app/usr/share/code/resources/app/out/vs/code/electron-sandbox/workbench/workbench.html) ```
Uses the new lexical types. Fully-typed nodes array, no more assertions
…subpath export in order to decrease module count when those are not used (#7660) This lowers the module count by 31 modules BREAKING: Migration-related lexical modules are now exported from `@payloadcms/richtext-lexical/migrate` instead of `@payloadcms/richtext-lexical`
- regenerates the lockfile - upgrades pnpm from v8 to v9.7.0 minimum - ensures playwright does not import payload config. Even after our importmap revamp that made the payload config server-only / node-safe, I was getting these `Error: Invariant: AsyncLocalStorage accessed in runtime where it is not available` errors in combination with pnpm v9 and lockfile regeneration. This does not happen with pnpm v8, however I'm still blaming playwright for this, as this does not happen in dev and we've had this specific error with playwright in the past when we were importing the payload config. Perhaps it's related to both playwright and the future Next.js process importing the same config file, and not related to the config file containing client-side React code. Making sure playwright doesn't import the config fixed it (it was importing it through the import map generation). The import map generation is now run in a separate process, and playwright simply waits for it - One positive thing: this pr fixes a bunch of typescript errors with react-select components. We got those errors because react-select types are not compatible with react 19. lockfile regeneration fixed that (not related to pnpm v9) - probably because we were installing mismatching react versions (I saw both `fb9a90fa48-20240614` and `06d0b89e-20240801` in our lockfile). I have thus removed the caret for react and react-dom in our package.json - now it's consistent
…ing from `Leave anyway` button (#7661)
…idate is enabled (#7678)
…ault edit view (#7673) ## Description We've since lost the ability to override the document view at the root-level. This was a feature that made it possible to override _the entire document routing/view structure_, including the document header/tabs and all nested routes within, i.e. the API route/view, the Live Preview route/view, etc. This is distinct from the "default" edit view, which _only_ targets the component rendered within the "edit" tab. This regression was introduced when types were simplified down to better support "component paths" here: #7620. The `default` key was incorrectly used as the "root" view override. To continue to support stricter types _and_ root view overrides, a new `root` key has been added to the `views` config. You were previously able to do this: ```tsx import { MyComponent } from './MyComponent.js' export const MyCollection = { // ... admin: { views: { Edit: MyComponent } } } ``` This is now done like this: ```tsx export const MyCollection = { // ... admin: { views: { edit: { root: { Component: './path-to-my-component.js' } } } } } ``` Some of the documentation was also incorrect according to the new component paths API. - [x] I have read and understand the [CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md) document in this repository. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [x] This change requires a documentation update ## Checklist: - [x] Existing test suite passes locally with my changes - [x] I have made corresponding changes to the documentation
…e component should not be rendered (#7682) If it's undefined/null => Fallback Component may be rendered If it's false => No component should be rendered - as if an empty component was passed in This ensures that the user does not have to install `@payloadcms/ui` anymore, which previously exported an empty component to be used in component paths
Bumps the github_actions group with 2 updates: [pnpm/action-setup](https://github.com/pnpm/action-setup) and [supercharge/mongodb-github-action](https://github.com/supercharge/mongodb-github-action). Updates `pnpm/action-setup` from 3 to 4 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pnpm/action-setup/releases">pnpm/action-setup's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <p>An error is thrown if one version of pnpm is specified in the <code>packageManager</code> field of <code>package.json</code> and a different version is specified in the action's settings <a href="https://redirect.github.com/pnpm/action-setup/pull/122">#122</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pnpm/action-setup/commit/fe02b34f77f8bc703788d5817da081398fad5dd2"><code>fe02b34</code></a> docs: bump action-setup version in README</li> <li><a href="https://github.com/pnpm/action-setup/commit/bee1f099e575ebe79c239f210b7b841a7597f87b"><code>bee1f09</code></a> feat: throw error when multiple versions specified (<a href="https://redirect.github.com/pnpm/action-setup/issues/122">#122</a>)</li> <li><a href="https://github.com/pnpm/action-setup/commit/ce859e384f8a1a0be70b423054e9fc15175c02a9"><code>ce859e3</code></a> refactor: replace <code>fs-extra</code> with Node.js built-in fs methods (<a href="https://redirect.github.com/pnpm/action-setup/issues/120">#120</a>)</li> <li><a href="https://github.com/pnpm/action-setup/commit/2ab6dce4f53589dada480b94c53cb05a06b04673"><code>2ab6dce</code></a> docs(README): fix link to LICENSE</li> <li><a href="https://github.com/pnpm/action-setup/commit/e280758d01dee817bb34e0eb1114fde6d3a9f1db"><code>e280758</code></a> docs(README): update dependency versions (<a href="https://redirect.github.com/pnpm/action-setup/issues/117">#117</a>)</li> <li><a href="https://github.com/pnpm/action-setup/commit/129abb77bf5884e578fcaf1f37628e41622cc371"><code>129abb7</code></a> Bump undici from 5.28.2 to 5.28.3 (<a href="https://redirect.github.com/pnpm/action-setup/issues/115">#115</a>)</li> <li>See full diff in <a href="https://github.com/pnpm/action-setup/compare/v3...v4">compare view</a></li> </ul> </details> <br /> Updates `supercharge/mongodb-github-action` from 1.10.0 to 1.11.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/supercharge/mongodb-github-action/releases">supercharge/mongodb-github-action's releases</a>.</em></p> <blockquote> <p>Release 1.11.0</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/supercharge/mongodb-github-action/blob/main/CHANGELOG.md">supercharge/mongodb-github-action's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/superchargejs/mongodb-github-action/compare/v1.10.0...v1.11.0">1.11.0</a> - 2024-05-22</h2> <h3>Added</h3> <ul> <li>added <code>mongodb-container-name</code> input: this option allows you to define the Docker container name</li> </ul> <h3>Fixed</h3> <ul> <li>use the <code>mongo</code> command to interact with MongoDB versions 4.x or lower. Previously, we only checked for MongoDB 4 and would use <code>mongosh</code> for MongoDB 3 (and lower). <a href="https://redirect.github.com/supercharge/mongodb-github-action/pull/61">Thanks to Aravind!</a></li> </ul> <h3>Updated</h3> <ul> <li>bump dependencies</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/5a87bd81f88e2a8b195f8b7b656f5cda1350815a"><code>5a87bd8</code></a> prepare changelog for 1.11.0</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/7c12fc679c61abd6c49e86a5d118631d93dcf039"><code>7c12fc6</code></a> update readme</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/ad7302955388d4b067d9cbd45d55465c6f3b951d"><code>ad73029</code></a> bump mongoose dependency</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/268fb2c93cce7b90118888a8f0e3c80b29bbbe0c"><code>268fb2c</code></a> Merge pull request <a href="https://redirect.github.com/supercharge/mongodb-github-action/issues/61">#61</a> from aravindnc/main</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/12b898a9c8b9f78358d57283a879ad38263c5283"><code>12b898a</code></a> Fix to use mongo client if MongoDB verison is less than or equal to 4.</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/b8277548e075c77cbebd996de03449994fd55594"><code>b827754</code></a> wait 20 seconds</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/5f37c5fb42fbfbb5590087b08a49e19c294c0b17"><code>5f37c5f</code></a> revert ESLint to 8.x</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/fcc7443a6b14085436ba76bb5f7db2f4b3c13c58"><code>fcc7443</code></a> bump verions</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/fde299bc7055896ded0abc3d9732847221bae2fa"><code>fde299b</code></a> bump deps</li> <li><a href="https://github.com/supercharge/mongodb-github-action/commit/9ceda80eded9ded87bbc5fa62fcafd976e2782d7"><code>9ceda80</code></a> bump versions of GitHub Actions</li> <li>Additional commits viewable in <a href="https://github.com/supercharge/mongodb-github-action/compare/1.10.0...1.11.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…7690) Updates no-relative-monorepo-import regex to handle more scenarios: ❌ Scenarios that will violate the rule: ```ts import { something } from '../../payload/src/utilities/some-util.js' import { something } from '../../../packages/payload/src/utilities/some-util.js' import { something } from 'packages/payload/src/utilities/some-util.js' ```
New rule to prevent a package from importing from itself.
jmikrut
requested review from
denolfe,
jacobsfletch and
jmikrut
as code owners
|
We fixed this and added the tests in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test fails on postgres and passes in mongodb
Type of change
Checklist: