Fix clippy warnings and add linting to CI #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal fields may be useful for debugging but shouldn't be displayed in error responses for privacy.
spacebear21
force-pushed
the
clippy-fixes
branch
3 times, most recently
from
4c6e426
to
d55656e
Compare
Run linting in more places (e.g. in tests, and with v2 features enabled).
spacebear21
force-pushed
the
clippy-fixes
branch
from
d55656e
to
2da1be5
Compare
This uses the path supplied `bash`, and will also allow the scripts to run on NixOS where `/usr/bin/env` is shimmed for compatibility but `/bin/bash` can't be relied on.
|
Thanks! |
spacebear21
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes clippy happy. Broke it up into one commit per fixed warning for easier review.
I also added a CI linting check which fails if
cargo clippyemits any warnings (and confirmed that this works by temporarily reverting a fix here).