Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around '#' escaping bug in bip21 crate #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Work around '#' escaping bug in bip21 crate #373

wants to merge 1 commit into from

Commits on Oct 23, 2024

  1. Work around '#' escaping bug in bip21 crate 

    bip21 dependency temporarily specified to use bugfix PR branch

The `pj` parameter of the BIP 21 URL is itself a URL which contains a
fragment.

This is not escaped by bip21 during serialization, which according to
RFC 3986 truncates the `pj` parameter, making everything that follows
part of the fragment.

Deserialization likewise ignores #, parsing it as part of the value
which round trips with the incorrect serialization behavior.

Temporarily depend on bugfix pr branch for bip21
    @nothingmuch
    nothingmuch committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ba0378c View commit details
    Browse the repository at this point in the history