Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convenience construction of a threefry #14

Closed
wants to merge 1 commit into from

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Mar 7, 2024

No description provided.

@nstarman nstarman marked this pull request as draft March 7, 2024 19:58
@nstarman
Copy link
Contributor Author

nstarman commented Mar 7, 2024

I think the test failures are unrelated.

@patrick-kidger
Copy link
Owner

Hmm, I think the test failures are probably due to a change in JAX. If you are able to fix that then I'd be happy to merge this.

@nstarman
Copy link
Contributor Author

nstarman commented Mar 9, 2024

I can't reproduce the error locally. Something in zeros.

@patrick-kidger
Copy link
Owner

Which version of JAX are you using? I suspect it's probably due to an update on their end.
(I haven't checked this myself yet.)

@nstarman
Copy link
Contributor Author

nstarman commented Mar 12, 2024

Which version of JAX are you using? I suspect it's probably due to an update on their end. (I haven't checked this myself yet.)

macOS
Python 3.12
jax[cpu] 0.4.25. I tried bumping to most recent jax in a clean environment.

@patrick-kidger
Copy link
Owner

Okay, so possibly an issue with the latest version of JAX! If this passes with an earlier version then that will be the culprit, and we'll need to figure out how to use JAX's changes.

@nstarman
Copy link
Contributor Author

Now that jax has a key type that isn't just an Array and can be used for annotations, this PR isn't necessary.

@nstarman nstarman closed this Jul 11, 2024
@nstarman nstarman deleted the prng-converter branch July 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants