Add a verbose option to BFGS. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Merged on to the |
|
Thanks! |
patrick-kidger
pushed a commit
that referenced
this pull request
Dec 24, 2024
* adding a verbose option to BFGS * adding default values for verbose option to custom BFGS solvers --------- Co-authored-by: Johanna Haffner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a verbose option to BFGS, with supports printing out the values of
loss,y, andstep_sizeat every step.The tested custom solvers are updated, and the documentation is updated as well.
Users that have written custom solvers that subclass BFGS will now see
ValueError: The following fields were not initialised during __init__: {'verbose'}upon upgrading.I think this - plus a note in the next release - is probably enough for the subset of users who define custom solvers (and probably know optimistix quite well). It is raised from inside equinox, though, which makes it a little less obvious. I'm happy to improve this - WDYT?
I have "tested" this by using it in a notebook, but not otherwise.
This follows up on #56 (comment).