Remove unused inner function #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A little thing I came across while slowly chipping away at my SQP implementation. This inner function does not seem to be used anywhere, and also does not seem to be an intentional holdover, as far as I can tell.
|
LGTM! Looks like the failing test is due to a breaking change in JAX that affects Lineax. I've opened patrick-kidger/lineax#110 as a possible fix (+Lineax version bump). I'll ignore it for now -- merged! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little thing I came across while slowly chipping away at my SQP implementation.
This inner function does not seem to be used anywhere, and also does not seem to be an intentional holdover, as far as I can tell.